"""Tests for /resume gateway slash command. Tests the _handle_resume_command handler (switch to a previously-named session) across gateway messenger platforms. """ from types import SimpleNamespace from unittest.mock import AsyncMock, MagicMock import pytest from gateway.config import Platform from gateway.platforms.base import MessageEvent from gateway.session import SessionSource, build_session_key def _make_event(text="/resume", platform=Platform.TELEGRAM, user_id="12345", chat_id="67890"): """Build a MessageEvent for testing.""" source = SessionSource( platform=platform, user_id=user_id, chat_id=chat_id, user_name="testuser", ) return MessageEvent(text=text, source=source) def _session_key_for_event(event): """Get the session key that build_session_key produces for an event.""" return build_session_key(event.source) def _make_runner(session_db=None, current_session_id="current_session_001", event=None): """Create a bare GatewayRunner with a mock session_store and optional session_db.""" from gateway.run import GatewayRunner runner = object.__new__(GatewayRunner) runner.adapters = {} runner.config = SimpleNamespace(platforms={}) runner._voice_mode = {} # Gateway holds the async facade; the slash handlers await it. if session_db is not None: from hermes_state import AsyncSessionDB session_db = AsyncSessionDB(session_db) runner._session_db = session_db runner._running_agents = {} runner._is_user_authorized = lambda _source: True # Compute the real session key if an event is provided session_key = build_session_key(event.source) if event else "agent:main:telegram:dm" # Mock session_store that returns a session entry with a known session_id mock_session_entry = MagicMock() mock_session_entry.session_id = current_session_id mock_session_entry.session_key = session_key mock_store = MagicMock() mock_store.get_or_create_session.return_value = mock_session_entry mock_store.load_transcript.return_value = [] mock_store.switch_session.return_value = mock_session_entry runner.session_store = mock_store return runner # --------------------------------------------------------------------------- # _handle_resume_command # --------------------------------------------------------------------------- class TestHandleResumeCommand: """Tests for GatewayRunner._handle_resume_command.""" @pytest.mark.asyncio async def test_no_session_db(self): """Returns error when session database is unavailable.""" runner = _make_runner(session_db=None) event = _make_event(text="/resume My Project") result = await runner._handle_resume_command(event) assert "not available" in result.lower() @pytest.mark.asyncio async def test_list_named_sessions_when_no_arg(self, tmp_path): """With no argument, lists recently titled sessions.""" from hermes_state import SessionDB db = SessionDB(db_path=tmp_path / "state.db") event = _make_event(text="/resume") lane_key = _session_key_for_event(event) db.create_session( "sess_001", "telegram", session_key=lane_key, user_id="12345", chat_id="67890", ) db.create_session( "sess_002", "telegram", session_key=lane_key, user_id="12345", chat_id="67890", ) db.set_session_title("sess_001", "Research") db.set_session_title("sess_002", "Coding") runner = _make_runner(session_db=db, event=event) result = await runner._handle_resume_command(event) assert "Research" in result assert "Coding" in result assert "Named Sessions" in result assert "1." in result assert "2." in result assert "/resume 1" in result db.close() @pytest.mark.asyncio async def test_resume_clears_session_model_overrides(self, tmp_path): """Resume must not carry a previous session's /model override into the restored conversation, while leaving other chats' overrides intact (#10702).""" from hermes_state import SessionDB db = SessionDB(db_path=tmp_path / "state.db") db.create_session("old_session_abc", "telegram", user_id="12345", chat_id="67890") db.set_session_title("old_session_abc", "My Project") db.create_session("current_session_001", "telegram", user_id="12345", chat_id="67890") event = _make_event(text="/resume My Project") runner = _make_runner(session_db=db, current_session_id="current_session_001", event=event) key = _session_key_for_event(event) runner._session_model_overrides = { key: {"model": "gpt-5", "provider": "openai"}, "agent:main:telegram:dm:other": {"model": "keep-me"}, } runner._pending_model_notes = { key: "[Note: switched to gpt-5]", "agent:main:telegram:dm:other": "[Note: keep-me]", } result = await runner._handle_resume_command(event) assert "Resumed" in result # The resumed chat's override + pending note are cleared... assert key not in runner._session_model_overrides assert key not in runner._pending_model_notes # ...but an unrelated chat's state is untouched. assert runner._session_model_overrides["agent:main:telegram:dm:other"] == {"model": "keep-me"} assert runner._pending_model_notes["agent:main:telegram:dm:other"] == "[Note: keep-me]" db.close() @pytest.mark.asyncio async def test_resume_clears_last_resolved_model(self, tmp_path): """Resume must also clear the resumed chat's cached last-resolved model, so the restored conversation re-resolves from current config instead of a value cached before the switch (mirrors /new and the compression-exhausted auto-reset, #58403), while leaving other chats' cache entries intact.""" from hermes_state import SessionDB db = SessionDB(db_path=tmp_path / "state.db") db.create_session("old_session_abc", "telegram", user_id="12345", chat_id="67890") db.set_session_title("old_session_abc", "My Project") db.create_session("current_session_001", "telegram", user_id="12345", chat_id="67890") event = _make_event(text="/resume My Project") runner = _make_runner(session_db=db, current_session_id="current_session_001", event=event) key = _session_key_for_event(event) runner._last_resolved_model = { key: "gpt-5", "agent:main:telegram:dm:other": "keep-me", } result = await runner._handle_resume_command(event) assert "Resumed" in result assert key not in runner._last_resolved_model assert runner._last_resolved_model["agent:main:telegram:dm:other"] == "keep-me" db.close() @pytest.mark.asyncio async def test_resume_follows_compression_continuation(self, tmp_path): """Gateway /resume should reopen the live descendant after compression.""" from hermes_state import SessionDB db = SessionDB(db_path=tmp_path / "state.db") db.create_session("compressed_root", "telegram", user_id="12345", chat_id="67890") db.set_session_title("compressed_root", "Compressed Work") db.end_session("compressed_root", "compression") db.create_session("compressed_child", "telegram", user_id="12345", chat_id="67890", parent_session_id="compressed_root") db.append_message("compressed_child", "user", "hello from continuation") db.create_session("current_session_001", "telegram", user_id="12345", chat_id="67890") event = _make_event(text="/resume Compressed Work") runner = _make_runner( session_db=db, current_session_id="current_session_001", event=event, ) runner.session_store.load_transcript.side_effect = ( lambda session_id: [{"role": "user", "content": "hello from continuation"}] if session_id == "compressed_child" else [] ) result = await runner._handle_resume_command(event) assert "Resumed session" in result assert "(1 message)" in result call_args = runner.session_store.switch_session.call_args assert call_args[0][1] == "compressed_child" runner.session_store.load_transcript.assert_called_with("compressed_child") db.close() @pytest.mark.asyncio async def test_resume_evicts_cached_agent(self, tmp_path): """Gateway /resume evicts the cached AIAgent so the next message rebuilds with the correct session_id end-to-end — mirrors /branch and /reset. Without this, the cached agent's memory provider keeps writing into the wrong session. See #6672. """ import threading from hermes_state import SessionDB db = SessionDB(db_path=tmp_path / "state.db") db.create_session("old_session", "telegram", user_id="12345", chat_id="67890") db.set_session_title("old_session", "Old Work") db.create_session("current_session_001", "telegram", user_id="12345", chat_id="67890") event = _make_event(text="/resume Old Work") runner = _make_runner(session_db=db, current_session_id="current_session_001", event=event) # Seed the cache with a fake agent real_key = _session_key_for_event(event) runner._agent_cache = {real_key: (MagicMock(), object())} runner._agent_cache_lock = threading.RLock() await runner._handle_resume_command(event) assert real_key not in runner._agent_cache db.close() @pytest.mark.asyncio async def test_bare_resume_lists_exact_lane_before_limit(self, tmp_path): from hermes_state import SessionDB db = SessionDB(db_path=tmp_path / "state.db") event = _make_event(text="/resume") lane_key = _session_key_for_event(event) for i in range(3): sid = f"lane_{i}" db.create_session( sid, "telegram", session_key=lane_key, user_id="12345", chat_id="67890", ) db.set_session_title(sid, f"Lane Work {i}") for i in range(12): sid = f"foreign_{i}" db.create_session( sid, "telegram", session_key=f"agent:main:telegram:dm:foreign-{i}", user_id=f"foreign-user-{i}", chat_id=f"foreign-{i}", ) db.set_session_title(sid, f"Foreign Work {i}") runner = _make_runner(session_db=db, event=event) result = await runner._handle_resume_command(event) assert "Lane Work 0" in result assert "Lane Work 1" in result assert "Lane Work 2" in result assert "Foreign Work" not in result db.close() @pytest.mark.asyncio async def test_bare_resume_admin_all_preserves_same_platform_widening(self, tmp_path): from hermes_state import SessionDB db = SessionDB(db_path=tmp_path / "state.db") event = _make_event(text="/resume --all") db.create_session( "other_lane", "telegram", session_key="agent:main:telegram:dm:other", user_id="other-user", chat_id="other", ) db.set_session_title("other_lane", "Other Lane Work") runner = _make_runner(session_db=db, event=event) runner._resume_caller_is_admin = lambda _source: True result = await runner._handle_resume_command(event) assert "Other Lane Work" in result db.close() @pytest.mark.asyncio async def test_numeric_resume_fallback_uses_exact_lane_candidates(self, tmp_path): from hermes_state import SessionDB db = SessionDB(db_path=tmp_path / "state.db") event = _make_event(text="/resume 2") lane_key = _session_key_for_event(event) db.create_session( "lane_older", "telegram", session_key=lane_key, user_id="12345", chat_id="67890", ) db.set_session_title("lane_older", "Lane Older") db.create_session( "lane_newer", "telegram", session_key=lane_key, user_id="12345", chat_id="67890", ) db.set_session_title("lane_newer", "Lane Newer") for i in range(12): sid = f"foreign_{i}" db.create_session( sid, "telegram", session_key=f"agent:main:telegram:dm:foreign-{i}", user_id=f"foreign-user-{i}", chat_id=f"foreign-{i}", ) db.set_session_title(sid, f"Foreign Work {i}") db.create_session( "current_session_001", "telegram", session_key=lane_key, user_id="12345", chat_id="67890", ) runner = _make_runner( session_db=db, current_session_id="current_session_001", event=event ) result = await runner._handle_resume_command(event) assert "Resumed" in result runner.session_store.switch_session.assert_called_once() assert runner.session_store.switch_session.call_args[0][1] == "lane_older" db.close() @pytest.mark.asyncio async def test_bare_resume_normalizes_telegram_lobby_source_to_bound_topic( self, tmp_path ): from hermes_state import SessionDB db = SessionDB(db_path=tmp_path / "state.db") event = _make_event(text="/resume") topic_source = SessionSource( platform=Platform.TELEGRAM, user_id="12345", chat_id="67890", chat_type="dm", thread_id="topic-42", ) topic_key = build_session_key(topic_source) db.create_session( "topic_session", "telegram", session_key=topic_key, user_id="12345", chat_id="67890", chat_type="dm", thread_id="topic-42", ) db.set_session_title("topic_session", "Recovered Topic Work") db.enable_telegram_topic_mode(chat_id="67890", user_id="12345") db.bind_telegram_topic( chat_id="67890", thread_id="topic-42", user_id="12345", session_key=topic_key, session_id="topic_session", ) lobby_key = _session_key_for_event(event) db.create_session( "lobby_session", "telegram", session_key=lobby_key, user_id="12345", chat_id="67890", chat_type="dm", ) db.set_session_title("lobby_session", "Lobby Work") runner = _make_runner(session_db=db, event=event) result = await runner._handle_resume_command(event) assert "Recovered Topic Work" in result assert "Lobby Work" not in result db.close() class TestHandleSessionsCommand: """Tests for GatewayRunner._handle_sessions_command.""" @pytest.mark.asyncio async def test_sessions_busy_platform_lists_exact_lane_and_excludes_current_tip( self, tmp_path ): from hermes_state import SessionDB db = SessionDB(db_path=tmp_path / "state.db") event = _make_event(text="/sessions") lane_key = _session_key_for_event(event) for i in range(11): sid = f"lane_root_{i}" db.create_session( sid, "telegram", session_key=lane_key, user_id="12345", chat_id="67890", ) db.set_session_title(sid, f"Lane Work {i}") db.create_session( "current_root", "telegram", session_key=lane_key, user_id="12345", chat_id="67890", ) db.set_session_title("current_root", "Current compressed root") db.end_session("current_root", "compression") db.create_session( "current_tip", "telegram", session_key=lane_key, user_id="12345", chat_id="67890", parent_session_id="current_root", ) db.set_session_title("current_tip", "Current compressed tip") for i in range(60): sid = f"foreign_{i}" db.create_session( sid, "telegram", session_key=f"agent:main:telegram:dm:foreign-{i}", user_id=f"foreign-user-{i}", chat_id=f"foreign-{i}", ) db.set_session_title(sid, f"Foreign Work {i}") runner = _make_runner( session_db=db, current_session_id="current_tip", event=event ) result = await runner._handle_sessions_command(event) assert result.count("Lane Work") == 10 assert "Lane Work 1" in result assert "Lane Work 0" not in result assert "Foreign Work" not in result assert "current_tip" not in result assert "current_root" not in result db.close() @pytest.mark.asyncio async def test_sessions_admin_all_preserves_cross_origin_widening(self, tmp_path): from hermes_state import SessionDB db = SessionDB(db_path=tmp_path / "state.db") event = _make_event(text="/sessions all") lane_key = _session_key_for_event(event) db.create_session( "tg_named", "telegram", session_key=lane_key, user_id="12345", chat_id="67890", ) db.set_session_title("tg_named", "Telegram Work") db.create_session( "discord_named", "discord", session_key="agent:main:discord:dm:other", user_id="other-user", chat_id="other", ) db.set_session_title("discord_named", "Discord Work") runner = _make_runner(session_db=db, event=event) runner._resume_caller_is_admin = lambda _source: True result = await runner._handle_sessions_command(event) assert "Telegram Work" in result assert "Discord Work" in result db.close() @pytest.mark.asyncio async def test_sessions_normalizes_telegram_lobby_source_to_bound_topic(self, tmp_path): from hermes_state import SessionDB db = SessionDB(db_path=tmp_path / "state.db") event = _make_event(text="/sessions") topic_source = SessionSource( platform=Platform.TELEGRAM, user_id="12345", chat_id="67890", chat_type="dm", thread_id="topic-42", ) topic_key = build_session_key(topic_source) db.create_session( "topic_session", "telegram", session_key=topic_key, user_id="12345", chat_id="67890", chat_type="dm", thread_id="topic-42", ) db.set_session_title("topic_session", "Recovered Topic Work") db.enable_telegram_topic_mode(chat_id="67890", user_id="12345") db.bind_telegram_topic( chat_id="67890", thread_id="topic-42", user_id="12345", session_key=topic_key, session_id="topic_session", ) lobby_key = _session_key_for_event(event) db.create_session( "lobby_session", "telegram", session_key=lobby_key, user_id="12345", chat_id="67890", chat_type="dm", ) db.set_session_title("lobby_session", "Lobby Work") runner = _make_runner(session_db=db, event=event) result = await runner._handle_sessions_command(event) assert "Recovered Topic Work" in result assert "Lobby Work" not in result db.close() @pytest.mark.asyncio async def test_sessions_all_does_not_leak_cross_origin_for_non_admin(self, tmp_path): """`/sessions all` from a non-admin caller must stay scoped to the caller's own origin — it must NOT enumerate other origins' sessions (the enumeration half of the /resume IDOR). Cross-origin listing is gated behind an explicitly-configured admin, which the default test config is not.""" from hermes_state import SessionDB db = SessionDB(db_path=tmp_path / "state.db") event = _make_event(text="/sessions all full") lane_key = _session_key_for_event(event) db.create_session( "tg_named", "telegram", session_key=lane_key, user_id="12345", chat_id="67890", ) db.set_session_title("tg_named", "Telegram Work") db.create_session("discord_unnamed", "discord") # other origin db.append_message("discord_unnamed", "user", "discord first prompt") runner = _make_runner(session_db=db, event=event) result = await runner._handle_sessions_command(event) # Caller's own (telegram) session is shown; the cross-origin (discord) # session is NOT leaked even with `all`. assert "Telegram Work" in result assert "discord_unnamed" not in result assert "Discord" not in result db.close() @pytest.mark.asyncio async def test_sessions_search_finds_older_titled_session(self, tmp_path): """`/sessions search ` matches titles beyond the recent-10 list and orders by activity, keeping the caller's own scope.""" from hermes_state import SessionDB db = SessionDB(db_path=tmp_path / "state.db") event = _make_event(text="/sessions search an94") lane_key = _session_key_for_event(event) # Bury the target under newer sessions so a plain listing misses it. db.create_session( "target_an94", "telegram", session_key=lane_key, user_id="12345", chat_id="67890", ) db.set_session_title("target_an94", "AN-94 Prestige Barrel Build #2") for i in range(12): sid = f"filler_{i}" db.create_session( sid, "telegram", session_key=lane_key, user_id="12345", chat_id="67890", ) db.set_session_title(sid, f"Filler {i}") runner = _make_runner(session_db=db, event=event) result = await runner._handle_sessions_command(event) assert "AN-94 Prestige Barrel Build #2" in result assert "target_an94" in result assert "Filler" not in result db.close() @pytest.mark.asyncio async def test_sessions_search_does_not_leak_other_users_sessions(self, tmp_path): """Search results honor the same owner-scoping guard as listing — a matching title owned by a different user/chat must not surface.""" from hermes_state import SessionDB db = SessionDB(db_path=tmp_path / "state.db") event = _make_event(text="/sessions search an94") lane_key = _session_key_for_event(event) db.create_session( "mine", "telegram", session_key=lane_key, user_id="12345", chat_id="67890", ) db.set_session_title("mine", "AN-94 mine") db.create_session( "theirs", "telegram", session_key="agent:main:telegram:dm:55555", user_id="99999", chat_id="55555", ) db.set_session_title("theirs", "AN-94 someone else's secret") runner = _make_runner(session_db=db, event=event) result = await runner._handle_sessions_command(event) assert "AN-94 mine" in result assert "theirs" not in result assert "secret" not in result db.close() @pytest.mark.asyncio async def test_resume_persisted_fallback_fails_closed_on_user_id_alt(self, tmp_path): """egilewski/CodeRabbit probe: Signal/Feishu key the session participant on ``user_id_alt or user_id`` (build_session_key), but the sessions table stores only user_id. So a persisted per-user row that a caller shares the user_id of — but NOT the user_id_alt — maps to a DIFFERENT live session key; the persisted fallback must NOT match it on user_id alone (IDOR). The live-origin guard already compares user_id_alt correctly; here the target is persisted-only, so the fallback fails closed whenever the caller keys on user_id_alt and the row can't prove that participant.""" from hermes_state import SessionDB db = SessionDB(db_path=tmp_path / "state.db") # Persisted rows carry only user_id (no user_id_alt column). db.create_session("victim_alt_group", "signal", user_id="+15550001111", chat_id="signal-group", chat_type="group") db.create_session("victim_alt_dm", "signal", user_id="+15550001111") # no chat_id runner = _make_runner(session_db=db) runner._gateway_session_origin_for_id = lambda sid: None # persisted-only # Per-user group: attacker shares user_id but has a different user_id_alt # → different session key → must fail closed (was: allowed via user_id). attacker = SessionSource(platform=Platform.SIGNAL, chat_id="signal-group", chat_type="group", user_id="+15550001111", user_id_alt="attacker-uuid") assert await runner._resume_target_allowed(attacker, "victim_alt_group", allow_override=False) is False # No-chat_id DM keyed purely on the participant: same block. dm_attacker = SessionSource(platform=Platform.SIGNAL, chat_id=None, chat_type="dm", user_id="+15550001111", user_id_alt="attacker-uuid") assert await runner._resume_target_allowed(dm_attacker, "victim_alt_dm", allow_override=False) is False # Regression: a caller WITHOUT user_id_alt (Telegram-style, keyed on # user_id) still resumes its own persisted per-user group row. tg_db = SessionDB(db_path=tmp_path / "state_tg.db") tg_db.create_session("own_group", "telegram", user_id="12345", chat_id="chat-a", chat_type="group") tg_runner = _make_runner(session_db=tg_db) tg_runner._gateway_session_origin_for_id = lambda sid: None tg_caller = SessionSource(platform=Platform.TELEGRAM, chat_id="chat-a", chat_type="group", user_id="12345") assert await tg_runner._resume_target_allowed(tg_caller, "own_group", allow_override=False) is True # Regression: an EXPLICITLY-shared group is unaffected — participant # scoping doesn't apply, so an alt-keyed co-member still resumes. runner.config.group_sessions_per_user = False assert await runner._resume_target_allowed(attacker, "victim_alt_group", allow_override=False) is True db.close() tg_db.close() @pytest.mark.asyncio async def test_gateway_dispatches_sessions_command(self, tmp_path): from hermes_state import SessionDB db = SessionDB(db_path=tmp_path / "state.db") db.create_session("tg_session", "telegram", user_id="12345", chat_id="67890") db.set_session_title("tg_session", "Telegram Work") event = _make_event(text="/sessions") runner = _make_runner(session_db=db, event=event) runner._handle_sessions_command = AsyncMock(return_value="sessions output") result = await runner._handle_message(event) assert result == "sessions output" runner._handle_sessions_command.assert_awaited_once_with(event) db.close() class TestSameOriginChatGroupScoping: """Live group sessions are per-user by default (group_sessions_per_user=True), so a co-member must not be able to resume another member's live group session via the live-origin branch of _resume_target_allowed (IDOR).""" @staticmethod def _src(user_id, *, chat_type="group", chat_id="guild-123", platform=Platform.DISCORD, user_id_alt=None, thread_id=None): return SessionSource(platform=platform, chat_id=chat_id, chat_type=chat_type, user_id=user_id, user_id_alt=user_id_alt, thread_id=thread_id) def test_dm_cross_user_blocked_without_chat_id(self): # No-chat_id DM: build_session_key falls back to the participant id # (user_id_alt or user_id), so two different participants are different # origins and must not match. (With a chat_id present the DM key IS the # chat_id — see test_dm_same_chat_id_is_same_origin.) runner = _make_runner() a = self._src("alice", chat_type="dm", chat_id=None) b = self._src("bob", chat_type="dm", chat_id=None) assert runner._same_origin_chat(a, b) is False @pytest.mark.asyncio async def test_resume_target_allowed_blocks_cross_user_live_group(self): """End-to-end via the live-origin branch: Alice cannot resume Bob's active group session in the same chat.""" runner = _make_runner() bob = self._src("bob") runner._gateway_session_origin_for_id = lambda sid: bob assert await runner._resume_target_allowed( self._src("alice"), "bobs_live_sid", allow_override=False ) is False # --- thread scoping: thread_id is part of the session key, so a session in # one thread must never match a caller in another thread of the same chat, # even when threads are shared among participants by default. --- def test_allows_same_thread_shared_participants(self): """Threads are shared by default (thread_sessions_per_user=False), so co-members in the SAME thread share the session.""" runner = _make_runner() a = self._src("alice", thread_id="thread-A") b = self._src("bob", thread_id="thread-A") assert runner._same_origin_chat(a, b) is True def test_blocks_thread_vs_no_thread(self): """A threaded origin must not match a non-threaded caller in the same parent chat (and vice versa).""" runner = _make_runner() threaded = self._src("alice", thread_id="thread-A") parent = self._src("alice", thread_id=None) assert runner._same_origin_chat(parent, threaded) is False assert runner._same_origin_chat(threaded, parent) is False class TestResumeRowVisibleMatrixAllScoping: """Non-admin Matrix `/resume --all` must NOT enumerate every Matrix titled session: the cross-room listing short-circuit is admin-only, mirroring the non-Matrix branch. A non-admin `--all` falls back to same-room scoping.""" @staticmethod def _matrix_src(chat_id="!room-a:hs", user_id="@alice:hs"): return SessionSource(platform=Platform.MATRIX, chat_id=chat_id, chat_type="group", user_id=user_id) @pytest.mark.asyncio async def test_non_admin_all_does_not_expose_other_room(self): runner = _make_runner() runner._resume_caller_is_admin = lambda src: False # Titled row whose live origin is a DIFFERENT Matrix room. other_room = SessionSource(platform=Platform.MATRIX, chat_id="!room-b:hs", chat_type="group", user_id="@bob:hs") runner._gateway_session_origin_for_id = lambda sid: other_room row = {"id": "sid_other_room"} assert await runner._resume_row_visible(self._matrix_src(), row, allow_all=True) is False class TestSameMatrixRoomThreadScoping: """Matrix `/resume` (direct and listing) scopes by room AND thread: a live session in another thread of the same room is a different session (build_session_key appends thread_id), so a caller in thread A must not resume/enumerate a target whose origin is in thread B. Non-threaded rooms keep room-level sharing unchanged.""" @staticmethod def _msrc(chat_id="!room-a:hs", user_id="@alice:hs", thread_id=None): return SessionSource(platform=Platform.MATRIX, chat_id=chat_id, chat_type="group", user_id=user_id, thread_id=thread_id) def test_same_room_no_thread_still_shared(self): runner = _make_runner() a = self._msrc(user_id="@alice:hs") b = self._msrc(user_id="@bob:hs") assert runner._same_matrix_room(a, b) is True def test_cross_thread_same_room_blocked(self): """The reviewer's probe: caller in thread-a, target origin in thread-b of the same room → must not match.""" runner = _make_runner() caller = self._msrc(thread_id="thread-a") victim_origin = self._msrc(thread_id="thread-b") assert runner._same_matrix_room(caller, victim_origin) is False